Change translation on the fly #3764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnorman
reviewed
Jan 19, 2017
| @@ -228,6 +228,7 @@ export function uiInit(context) { | |||
|
|
|||
| var mapDimensions = map.dimensions(); | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
fwiw, I've been adding 2 spaces before function blocks and anywhere else I want documentation to go.
| @@ -247,6 +248,7 @@ export function uiInit(context) { | |||
| }; | |||
| } | |||
|
|
|||
|
|
|||
I'm pretty close to merging it, but you can check out this branch and when running, open a developer console call
etc... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to fix the history and map flying to some random area.
cc: @bhousel